open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
234 stars 43 forks source link

finalization of third party custom elements support #173

Closed tlouisse closed 2 years ago

tlouisse commented 2 years ago

This PR is a continuation of https://github.com/open-wc/custom-elements-manifest/pull/142 (it was almost finished)

As discussed, the commit history of https://github.com/open-wc/custom-elements-manifest/pull/142 was squashed, so it was easier to rebase with master. Because of the latter, this pr goes directly into master.

On top of your squashed commit, it has:

Let me know if you want to organize the commit history in a different way.

netlify[bot] commented 2 years ago

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
Latest commit 63264a1177e6a7205f2f3c9eecc51fdff874b73b
Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/628c0863af19530008cde570
Deploy Preview https://deploy-preview-173--custom-elements-manifest-analyzer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thepassle commented 2 years ago

Could you update the version of find-dependencies in the package.json?

tlouisse commented 2 years ago

@thepassle added a (deliberately failing) test for symlinked monorepo packages

thepassle commented 2 years ago

Thanks for pushing for this and getting it across the finish line!