search

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
234 stars 43 forks source link

Chore: Add @asdgf/cli as dev dependency #192

Closed Matsuuu closed 1 year ago

Matsuuu commented 1 year ago

Heya,

Noticed that the project uses asdgf to test the project but didn't pack it as a dev dependency at least in the analyzer. Added the package as a dev dep

netlify[bot] commented 1 year ago

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
Latest commit 9a7b25b1ab1fbc6ef5cf54308e85eb4205e99b79
Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/639380de7dfdc400081990e8
Deploy Preview https://deploy-preview-192--custom-elements-manifest-analyzer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thepassle commented 1 year ago

Dev dependencies are hoisted in a (yarn workspaces) monorepo, so no need to install it in the package itself

Matsuuu commented 1 year ago

Ah gotcha. Just noticed that too yeah.

But that means that you always have to run all of the tests for all of the packages, right?

Would it hurt to have the import also in the dev deps ofthe package itself?

thepassle commented 1 year ago

You can run yarn from the monorepo root to install deps, and then you can cd packages/analyzer and yarn test to only run the tests for that specific package

Id prefer not to add the dep to the package specifically for consistency and to avoid different versions across the monorepo

Matsuuu commented 1 year ago

Ah Wasn't aware you could still run the test from the package itself. Yeah let's close this one

thepassle commented 1 year ago

Probably should add this info in a CONTRIBUTING.md as well 😅