fix: add support for globalThis.customElements

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.

https://custom-elements-manifest.open-wc.org/

226 stars 37 forks source link

Closed luwes closed 11 months ago

luwes commented 11 months ago

thanks for a great package!

this adds support for using globalThis.customElements.define() which could be more and more used in the future.

we recently changed our library to use globalThis.customElements.define() to avoid polluting window https://github.com/muxinc/media-chrome/commit/f620c1ea37c6618d9c621a983baa088e8f9b6f0d

and the tagName's disappeared from the custom elements manifest...

netlify[bot] commented 11 months ago

Name	Link
Latest commit	c1be851408dd260b814e8ed564390d905510464b
Latest deploy log	https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/64b7416ed14d510008b598fa
Deploy Preview	https://deploy-preview-216--custom-elements-manifest-analyzer.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thepassle commented 11 months ago

Published as 0.8.4, thanks for the contribution :)