Analyzer error when extending a mixin with a typescript type param

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.

https://custom-elements-manifest.open-wc.org/

234 stars 43 forks source link

Analyzer error when extending a mixin with a typescript type param #231

Closed matteematt closed 4 months ago

matteematt commented 8 months ago

Checklist

[X] Did you run the analyzer with the --dev flag to get more information?
[ ] Did you create a minimal reproduction in the playground? - doesn't crash on there for some reason

Completing the items above will greatly improve triaging time of your issue.

Expected behavior A clear and concise description of what you expected to happen.

The analyzer is crashing in the analyze phase when there is a class that extends a mixin, where the mixin parameter is a class with a typescript type param

export class A extends MixinFn(B<C>) {}

See gif analyzer_error

thepassle commented 4 months ago

Im unable to reproduce, please provide a reproduction in the playground as mentioned in the issue template.

DRiFTy17 commented 4 months ago

@thepassle I was running into this for a while as well, but just updated to 0.10.2 and it's working fine for me now so I think we're all set. I narrowed it down to a change between 0.9.3 (not working) and 0.9.4 (working) in case anyone else runs into this one.

thepassle commented 4 months ago

Thanks for confirming 👍

matteematt commented 4 months ago

@DRiFTy17 thanks, I was struggling to recreate it locally and wasn't able to, and didn't have much time to dig into it. I guess it was because it was fixed. Thanks!