search

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
243 stars 45 forks source link

fix: path parsing on Windows (non-unix) #235

Open bheston opened 9 months ago

bheston commented 9 months ago

Fix an issue running analyzer in a monorepo with a reference to custom elements in another package. The find-dependencies package converts the path to Unix format, but then uses path.sep to parse the path. On Windows the separators are not the same so it fails.

I tried to add a test for this case, but that branch needs to read the package.json file which I don't believe can happen in the mocked test environment.

netlify[bot] commented 9 months ago

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
Latest commit 3683e7a9a78a02e7035832e0f2c7980bf5cd5ebc
Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/65d2a172a02f0d00080e6d50
Deploy Preview https://deploy-preview-235--custom-elements-manifest-analyzer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.