[Analyzer] `InitializeParams` type missing from `index.d.ts`

xenobytezero commented 4 months ago

Checklist

[ x] Did you run the analyzer with the --dev flag to get more information? - N/A
[ x] Did you create a minimal reproduction in the playground? - N/A

I'm importing the @custom-elements-manifest/analyzer types to help writing a plugin, and tsc is complaining the following

../../../node_modules/.pnpm/@custom-elements-manifest+analyzer@0.9.2/node_modules/@custom-elements-manifest/analyzer/index.d.ts:95:23 - error TS2304: Cannot find name 'InitializeParams'.

95   initialize?(params: InitializeParams): void;
                         ~~~~~~~~~~~~~~~~

Found 1 error in ../../../node_modules/.pnpm/@custom-elements-manifest+analyzer@0.9.2/node_modules/@custom-elements-manifest/analyzer/index.d.ts:95

Sure enough, this type is missing, and is flagged as an error when opening the file up in VSCode.

I can work around the issue using skipLibCheck but I am assuming this omission is a mistake, and thought I should flag it.

thepassle commented 4 months ago

Ah yes, we recently added this hook but I guess forgot to update the .d.ts file. Would you mind creating a PR? :)

xenobytezero commented 4 months ago

Will do.

xenobytezero commented 4 months ago

Done!

thepassle commented 4 months ago

Released in 0.9.3

open-wc / custom-elements-manifest

[Analyzer] `InitializeParams` type missing from `index.d.ts` #237