Closed KonnorRogers closed 7 months ago
Name | Link |
---|---|
Latest commit | fc085e386f8b0be81c6ce042d57583acd9c9dead |
Latest deploy log | https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/66394eb0be10930008350907 |
Deploy Preview | https://deploy-preview-247--custom-elements-manifest-analyzer.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
should we also analyze for this.internals.states.add("foo")
?
During class analysis we can see if this.attachInternals()
is assigned to something, keep that something in memory, and then see if <whatever>.states.add("foo")
is being called with a string ("foo"
) on it?
Fixes #246
I went with
@customState
instead of@state
to disambiguate from@state()
decorator from Lit.
this for me feels correct but also not attached to a name as long as its specific enough if your looking bit in to the future there going to be more exposed things other then parts and these customState/cssState might be hard to keep these consistant like cross-root-aria proposal if the exportids is uses then you would get ids :)
should we also analyze for
this.internals.states.add("foo")
?During class analysis we can see if
this.attachInternals()
is assigned to something, keep that something in memory, and then see if<whatever>.states.add("foo")
is being called with a string ("foo"
) on it?
Sounds similar to how events are "discovered", so I don't see why not
@KonnorRogers https://github.com/webcomponents/custom-elements-manifest/pull/128 was merged, can you update this PR? :)
@thepassle updated to use @cssstate
and @cssState
pushing to cssStates
array.
I also updated the README to reflect the new supported tag.
I also added a new fixture directory for it.
Thanks for the PR! Published in 0.10.0
Fixes #246
I went with
@customState
instead of@state
to disambiguate from@state()
decorator from Lit.