search

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
226 stars 37 forks source link

Add support for "@attribute" in "PropertyDeclarations" and in Constructor bodies #252

Closed KonnorRogers closed 1 month ago

KonnorRogers commented 2 months ago

Fixes #250 and #251

netlify[bot] commented 2 months ago

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
Latest commit 011036116a1ce7b40d72e390addd5b463431a573
Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/66393c98c7748c0008dd3100
Deploy Preview https://deploy-preview-252--custom-elements-manifest-analyzer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thepassle commented 1 month ago

LGTM, can you add a testcase in packages/analyzer/fixtures/06-jsdoc/default/package/my-element.js? fixture/custom-elements.json is the expected state, and output.json is what CEM/A outputs, so you should update fixture/custom-elements.json manually with the changes. Lemme know if you need any help or if its unclear :)

KonnorRogers commented 1 month ago

@thepassle added!

thepassle commented 1 month ago

Thanks for the PR :) Released in 0.9.9