open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
226 stars 37 forks source link

The analyzer doesn't ignore nested node_modules by default #256

Open andrico1234 opened 1 month ago

andrico1234 commented 1 month ago

Checklist

I'm using the CLI to generate a CEM for a monorepo.

For large monorepos, the analyzer hangs for a long time, since it's analyzing files inside of nested node_modules.

You can see in the repro that the output contains modules that live within node_modules directory

This suggests that by default it doesn't ignore nested node_modules. After looking into the source it seems that the default ignore pattern for node_modules is "!node_modules/**.". My guess is that this ignores the top-level node modules. By adding the following pattern "*\/node_modules/**" the analyzer avoids going through the nested modules

Completing the items above will greatly improve triaging time of your issue.

Expected behavior Ignore node_modules at all levels by default

I'll be happy to create a PR if this is something that you feel should live in the repo

thepassle commented 1 month ago

Can you create a pr?