search

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
226 stars 37 forks source link

web: don't fail when `name.text` is undefined #261

Open kensternberg-authentik opened 2 weeks ago

kensternberg-authentik commented 2 weeks ago

The check here is that node.name can be undefined; we then know that the node is private. But node.name.text can be undefined, and that should also not throw an exception at this check. I've added a small check to ensure this won't throw.

netlify[bot] commented 2 weeks ago

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
Latest commit 2b70efafd31fe8d0a5c6a62152ab29a0e393f192
Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/667314a2bafeaf000849752e
Deploy Preview https://deploy-preview-261--custom-elements-manifest-analyzer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thepassle commented 2 weeks ago

in which case can it be undefined?

rkaraivanov commented 19 hours ago

in which case can it be undefined?

264