`custom-element-definition` does not get added to elements if you use a helper on base class. - Githubissues

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.

https://custom-elements-manifest.open-wc.org/

243 stars 45 forks source link

`custom-element-definition` does not get added to elements if you use a helper on base class. #273

Open KonnorRogers opened 3 months ago

KonnorRogers commented 3 months ago

Checklist

[x] Did you run the analyzer with the --dev flag to get more information?
[x] Did you create a minimal reproduction in the playground?

Reproduction: https://custom-elements-manifest.netlify.app/?source=CmNsYXNzIEJhc2VFbGVtZW50IGV4dGVuZHMgSFRNTEVsZW1lbnQgewogIHN0YXRpYyBiYXNlTmFtZSA9ICIiCiAgc3RhdGljIGRlZmluZSAoYmFzZU5hbWUgPSB0aGlzLmJhc2VOYW1lLCBjdG9yID0gdGhpcywgYWRkaXRpb25hbE9wdGlvbnMpIHsKICAgICAgLy8gVGhpcyBpbXByb3Blcmx5IGNyZWF0ZXMgYSBgY3VzdG9tLWVsZW1lbnQtZGVmaW5pdGlvbmAKICAgICAgY3VzdG9tRWxlbWVudHMuZGVmaW5lKGJhc2VOYW1lLCBjdG9yLCBhZGRpdGlvbmFsT3B0aW9ucykKICB9Cn0KCmNsYXNzIE15RWxlbWVudCBleHRlbmRzIEJhc2VFbGVtZW50IHsKICAgIHN0YXRpYyBiYXNlTmFtZSA9ICJteS1lbGVtZW50Igp9CgoKLy8gVGhpcyBzaG91bGQgY3JlYXRlIGEgYGN1c3RvbS1lbGVtZW50LWRlZmluaXRpb25gLCBidXQgZG9lc24ndC4KTXlFbGVtZW50LmRlZmluZSgpCg%3D%3D&library=null

Completing the items above will greatly improve triaging time of your issue.

Expected behavior

Adding a define helper to a base class should be trackable and added to the manifest.

Barring this, a user should be able to do something like @define or something to signify to CEM that the element is getting registered.