search

open-wc / form-participation

Helper, mixins, tools, and more for supporting your custom elements in participating in an ancestor form.
MIT License
53 stars 7 forks source link

feat(form-control): simplify scenario where the validationTarget is not set when the constructor runs #44

Closed calebdwilliams closed 1 year ago

calebdwilliams commented 1 year ago

I definitely would like this tested, should related to #39

calebdwilliams commented 1 year ago

I believe this is an improvement either way, but would love for either @muratcorlu or @hrmcdonald to let me know if this fixed any weirdness on their ends before merging. If I don't hear anything by tomorrow morning I'll go ahead and merge this.

muratcorlu commented 1 year ago

@calebdwilliams I tested this code within our project and now all validation and custom message logic look working very well to me. 😊

Please release the latest changes once you merge this so we can use them right away.

hrmcdonald commented 1 year ago

I believe this is an improvement either way, but would love for either @muratcorlu or @hrmcdonald to let me know if this fixed any weirdness on their ends before merging. If I don't hear anything by tomorrow morning I'll go ahead and merge this.

Sorry for the late response, I'll check things out tonight! If y'all get anything merged and I have a scenario this doesn't cover I can open up a different issue for whatever that might be.

calebdwilliams commented 1 year ago

@muratcorlu Perfect. I'll count this as working then. @hrmcdonald if you have any other issues, please feel free to open a separate thread, but it looks like the initial issue is fully resolved now so I'll merge this and close out that issue.

Thanks y'all!