open-wc / form-participation

Helper, mixins, tools, and more for supporting your custom elements in participating in an ancestor form.
MIT License
53 stars 7 forks source link

fix(helpers): change submit event type to Event #49

Closed michaelwarren1106 closed 1 year ago

michaelwarren1106 commented 1 year ago

changing the submit event type from SubmitEvent to just Event increases jsdom compatibility to versions less than 21.x

Currently, folks running tests in jest with the latest jest-environment-jsdom will get ^20.0.0 which doesn't have SubmitEvent implemented. Having SubmitEvent would force an npm package override to jsdom ^21 which shouldn't really be necessary. IMO when jest-environment-jsdom updates we could change back to SubmitEvent as a patch bump again.