formControlValidationGroup implementation missing

open-wc / form-participation

Helper, mixins, tools, and more for supporting your custom elements in participating in an ancestor form.

MIT License

53 stars 7 forks source link

formControlValidationGroup implementation missing #52

Open vospascal opened 9 months ago

vospascal commented 9 months ago

i saw a example using formControlValidationGroup now i checked the code and the history on formControlValidationGroup there was a pr from @calebdwilliams but i dont think there is any current implementation using formControlValidationGroup was this intentionaly?

is there a work around for this so you can validate radio input groups? if not ill see if i can help with a implemention to put it back in

it use to be added with this pr https://github.com/open-wc/form-participation/pull/12

i also see formValidationGroup still in there

calebdwilliams commented 9 months ago

Hmmm, it was there at one point and it’s in the documentation. Would be happy to field a PR adding it back in.

vospascal commented 9 months ago

yea that would be great @calebdwilliams if its not to much work i think its needed to be able to validate a radio group

vospascal commented 9 months ago

i did some more digging looks like this pr removed it https://github.com/open-wc/form-participation/pull/27/files#diff-2e8511e42c76675f162dfdff43cb64c3311aa31b11174728477def4f6bde28daL366 @calebdwilliams

Goldflow commented 8 months ago

@vospascal fyi, I received this info from one of the repository's code owners (when I said formControlValidationGroup was missing & I needed help for implementing radio & radio-group web components)