Check Rust feature configs

open-web3-stack / open-runtime-module-library

Substrate Open Runtime Module Library

Apache License 2.0

447 stars 289 forks source link

Check Rust feature configs #964

Closed ggwpez closed 7 months ago

ggwpez commented 8 months ago

Adds the Zepter CLI to the CI to verify feature integrity of all Rust crates. It uses (nearly) the same config file as the Polkadot-SDK.
cc @AurevoirXavier maybe you also want to add your tool?

What it does:

Formats the features with 80 line width.
Checks that try-runtime, runtime-benchmarks and std is forwarded to dependencies.
Skips the check that if crate B has a feature that crate A also must have that feature (we skipped this in the SDK, but could be enabled).

codecov[bot] commented 8 months ago

Codecov Report

Merging #964 (1993e51) into master (0abce5c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files          88       88           
  Lines       10476    10476           
=======================================
  Hits         8939     8939           
  Misses       1537     1537

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

AurevoirXavier commented 7 months ago

cc @AurevoirXavier maybe you also want to add your tool?

Sure, thank you. However, I am currently waiting for my new laptop, so I will be unavailable for a brief period.

ggwpez commented 7 months ago

Sure, thank you. However, I am currently waiting for my new laptop, so I will be unavailable for a brief period.

Okay nice. I am waiting for @xlc for some feedback on the approach.

AurevoirXavier commented 7 months ago

Currently, cargo-featalign requires a kitchensink-runtime or similar to perform the checks which is more accurate.