Closed RomarQ closed 4 months ago
Updating dependencies in Cargo.dev.toml since the crates have been updated in crates.io.
@xlc Could you have a look at the changes? Thank you in advance :)
Attention: Patch coverage is 80.50633%
with 77 lines
in your changes are missing coverage. Please review.
Project coverage is 85.25%. Comparing base (
c7910d3
) to head (68fdf4d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I prefer to leave upgrade to XCM v4 on a separate PR and I prefer only upgrade to it when it is thoroughly tested (e.g. when it is used by system parachains on testnets). There were enough bugs on v3 upgrades and we shouldn't take lightly on upgrading to v4.
Not sure it will be possible to not upgrade to XCM v4 since xcm-executor
uses xcm::latest
, I will try to have something minimal with a converter between V4 and V3.
More info: https://github.com/paritytech/polkadot-sdk/issues/3214
I think the only breaking change regarding the SCALE encoding is the AssetId
since the Abstract
variant has been removed.
I will say it will be a major regression in polkadot-sdk if we are forced to use xcm v4 and if that’s actually the case, we need polkadot-sdk to be patched first.
with https://github.com/paritytech/polkadot-sdk/pull/3328 we won't get 100% compatibility between v4 types and v3 types
Update polkadot-sdk to version 1.7.0
Includes many xcm changes, which were introduced in https://github.com/paritytech/polkadot-sdk/pull/1230.
To reduce the amount of breaking changes I did not remove the
multi
prefix from extrinsics in thextokens
pallet:I tested the changes against https://github.com/paritytech/polkadot-sdk/tree/release-polkadot-v1.7.0