open-webrtc-toolkit / owt-client-android

Open WebRTC Toolkit client SDK for Android applications.
https://01.org/open-webrtc-toolkit
Apache License 2.0
195 stars 96 forks source link

Android SDK will crash if subscribe simulcast stream with invalid codec settings #146

Open yanbin7 opened 4 years ago

yanbin7 commented 4 years ago

Steps:

  1. Using Chrome browser to publish simulcast stream , stream resolution is 640x360, codec is vp8 option is publishOptions = { audio : true, video : [ {codecPayloadType:125,rid: 'h', active: true, scaleResolutionDownBy: 2.0}, {codecPayloadType:125,rid: 'f', active: true} ]

  2. Use Android client subscribe simulcast stream with invalid codec settings H264.

/owt.sample.conference E/AndroidRuntime: FATAL EXCEPTION: pool-9-thread-1 Process: owt.sample.conference, PID: 30832 java.lang.NullPointerException: Attempt to invoke virtual method 'void owt.conference.Subscription.onError(owt.base.OwtError)' on a null object reference at owt.conference.ConferenceClient.onError(ConferenceClient.java:895) at owt.conference.ConferencePeerConnectionChannel.lambda$onSetFailure$23$ConferencePeerConnectionChannel(ConferencePeerConnectionChannel.java:118) at owt.conference.-$$Lambda$ConferencePeerConnectionChannel$SuZqmJsooiK8I2_SjeocaJFNI2E.run(Unknown Source:4) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:764)