Fixed some possible null pointer crashes and race condition issues - Githubissues

open-webrtc-toolkit / owt-client-android

Open WebRTC Toolkit client SDK for Android applications.

https://01.org/open-webrtc-toolkit

Apache License 2.0

194 stars 96 forks source link

Fixed some possible null pointer crashes and race condition issues #267

Closed bert-and-ernie closed 3 years ago

bert-and-ernie commented 3 years ago

The MediaStream in Stream can be disposed on subscribe, ConferenceClient checks if stream is not disposed in subscribe.
The MediaStream in Stream can be disposed before publish, ConferenceClient checks if not already disposed before publish.
Stream instance in ConferencePeerConnectionChannel can be null in function ConferenceClient.subscribe()
Added extra checks and synchronized block in ConferenceClient.onStreamUpdated() when using remoteStreams

A large part of this pull request was accepted earlier but was not merged( https://github.com/open-webrtc-toolkit/owt-client-android/pull/239 ).

Improved code from the last pull request and included the previous changes.

bert-and-ernie commented 3 years ago

You're welcome, thank you for merging the PR