open-webrtc-toolkit / owt-client-native

Open WebRTC Toolkit client SDK for native Windows/Linux/iOS applications.
https://01.org/open-webrtc-toolkit
Apache License 2.0
391 stars 180 forks source link

Certificate fingerprint length is not null terminated #540

Closed brgavino closed 3 years ago

brgavino commented 3 years ago

When copying a user provided certificate fingerprint, the string is not copied with a null terminator which results in the error similar to

[0708/100210.214:WARNING:web_transport_fingerprint_proof_verifier.cc(89)] Invalid fingerprint length [0708/100210.214:WARNING:quic_transport_client.cc(55)] Failed to add a certificate fingerprint: B5:1B:D3:56:4A:D7:37:47:9C:0F:63:7F:E8:D5:28:75:54:8C:F3:17:B4:D7:8E:BB:AE:DB:C7:9B:69:E4:E1:01ýýýýÝ

https://github.com/open-webrtc-toolkit/owt-client-native/blob/7a812df8a6567efa096f2deb09a6edfb307a11ba/talk/owt/sdk/conference/conferencewebtransportchannel.cc#L102