Receiving session_id can fail in WebTransport without notice to the user

open-webrtc-toolkit / owt-client-native

Open WebRTC Toolkit client SDK for native Windows/Linux/iOS applications.

https://01.org/open-webrtc-toolkit

Apache License 2.0

389 stars 181 forks source link

Open tfrankow-intel opened 2 years ago

tfrankow-intel commented 2 years ago

Receiving the session_id is only attempted 5 times. If it fails to read it in time, the subscription process goes on as if everything is ok, even though it is a fatal issue. https://github.com/open-webrtc-toolkit/owt-client-native/blob/a0e63dae4140a1d119ac1ec68ca528386f473b90/talk/owt/sdk/conference/conferencewebtransportchannel.cc#L435

jianjunz commented 2 years ago

JavaScript SDK reads session ID when new data is received. It's better to change the implementation to async mode.