open-webrtc-toolkit / owt-client-native

Open WebRTC Toolkit client SDK for native Windows/Linux/iOS applications.
https://01.org/open-webrtc-toolkit
Apache License 2.0
385 stars 180 forks source link

`Stream::AttachAudioPlayer` may cause WebRTC `SIGABRT` #611

Open chuigda opened 1 year ago

chuigda commented 1 year ago

According to this

https://github.com/open-webrtc-toolkit/owt-client-native/blob/dffb087843165e3a32782166de39ee69449035ee/talk/owt/sdk/base/stream.cc#L191-L194

old_renderer may be nullptr, but in WebRTC side code:

图片

And this could cause WebRTC SIGABRT.

图片

图片

图片

Fixing this problem, I think, could be one trivial step.