open-webrtc-toolkit / owt-client-native

Open WebRTC Toolkit client SDK for native Windows/Linux/iOS applications.
https://01.org/open-webrtc-toolkit
Apache License 2.0
385 stars 180 forks source link

Is it meaningless code? [File: stream.cc] #615

Open yy-tayu opened 1 year ago

yy-tayu commented 1 year ago

Hi, In the file stream.cc, I found several strange codes as follows:

LocalStream::LocalStream(const LocalCameraStreamParameters& parameters,
                         int& error_code) {
    //do something...
    **rtc::scoped_refptr<webrtc::VideoCaptureModule> capturer(nullptr);**
    //do something...
}

LocalStream::LocalStream(
    std::shared_ptr<LocalDesktopStreamParameters> parameters,
    std::unique_ptr<LocalScreenStreamObserver> observer) {
    //do something...
    **std::unique_ptr<BasicDesktopCapturer> capturer(nullptr);**
    //do something...
}

LocalStream::LocalStream(
    std::shared_ptr<LocalCustomizedStreamParameters> parameters,
    std::unique_ptr<VideoFrameGeneratorInterface> framer) {
    //do something...
  **std::unique_ptr<CustomizedFramesCapturer> capturer(nullptr);**
    //do something...
}

LocalStream::LocalStream(
    std::shared_ptr<LocalCustomizedStreamParameters> parameters,
    VideoEncoderInterface* encoder) {
    //do something...
    **std::unique_ptr<CustomizedFramesCapturer> capturer(nullptr);**
    //do something...
}

Why? Thanks in advance!