search

open-webrtc-toolkit / owt-client-native

Open WebRTC Toolkit client SDK for native Windows/Linux/iOS applications.
https://01.org/open-webrtc-toolkit
Apache License 2.0
384 stars 180 forks source link

Add support for both CG server and client build. #704

Closed jianjunz closed 1 year ago

jianjunz commented 1 year ago

Update scripts and GN files to support CG client build on Windows.

jianjunz commented 1 year ago

msdk_root is not mandatory. But if msdk_root is not provided, HEVC will not be supported.

This change depends on https://github.com/open-webrtc-toolkit/owt-deps-webrtc/pull/192.

jianjunz commented 1 year ago

Change is missing, so configuration fails:

ERROR at //third_party/webrtc/BUILD.gn:482:7: Undefined identifier
  if (owt_cloud_gaming) {
      ^---------------
See //talk/owt/BUILD.gn:112:9: which caused the file to be included.
        "//third_party/webrtc",
        ^---------------------

As mentioned above, this change depends on https://github.com/open-webrtc-toolkit/owt-deps-webrtc/pull/192.

dvrogozh commented 1 year ago

Building as:

python3 .\scripts\build-win.py --gn_gen --sdk --cg_client --output_path dist-client-x64 --scheme release --arch x64 --ffmpeg_root=C:\build-install --ssl_root=C:\build-install

fails with:

C:\buildhome\src\talk/owt/sdk/base/win/msdkvideobase.h(13): fatal error C1083: Cannot open include file: 'mfxdefs.h': No such file or directory

I thought if you don't specify --msdk-root, you still can build but loose HEVC/AV1 decoding?

jianjunz commented 1 year ago

Covered by #705. Closing this one.