search

open-webrtc-toolkit / owt-server

General server (streaming/conference/transcoding/anayltics) for OWT. (A.k.a. MediaServer)
https://01.org/open-webrtc-toolkit
Apache License 2.0
1.13k stars 368 forks source link

ENABLE_SVT_HEVC_ENCODER no effect #889

Open zhzhjr opened 3 years ago

zhzhjr commented 3 years ago

owt-server/source/agent/video/videoMixer/VideoFrameMixerImpl.h line 259

if ENABLE_SVT_HEVC_ENCODER

    if (!encoder && format == owt_base::FRAME_FORMAT_H265)
        encoder.reset(new owt_base::SVTHEVCEncoder(format, profile, m_useSimulcast));

endif

Should be changed to:

ifdef ENABLE_SVT_HEVC_ENCODER

    if (!encoder && format == owt_base::FRAME_FORMAT_H265)
        encoder.reset(new owt_base::SVTHEVCEncoder(format, profile, m_useSimulcast));

endif

line 214

if ENABLE_SVT_HEVC_ENCODER

if (!encoder && format == owt_base::FRAME_FORMAT_H265)
    encoder.reset(new owt_base::SVTHEVCEncoder(format, profile));

endif

Should be changed to:

ifdef ENABLE_SVT_HEVC_ENCODER

if (!encoder && format == owt_base::FRAME_FORMAT_H265)
    encoder.reset(new owt_base::SVTHEVCEncoder(format, profile));

endif

Or modify owt-server/source/agent/video/videoTranscoder/videoTranscoder_sw/binding.sw.gyp owt-server/source/agent/video/videoMixer/videoMixer_sw/binding.sw.gyp

daijh commented 3 years ago

Thanks for pointing out the typo in code. Luckily, -DENABLE_SVT_HEVC_ENCODER give default value as 1, and the code happens to work well.

Definitely, the typo should be fixed. Do you like to submit a PR?