open-webui / helm-charts

53 stars 37 forks source link

feature: Add Label Configuration for ollama Service in values.yaml #10

Closed stepanbaghdasaryan closed 4 months ago

stepanbaghdasaryan commented 4 months ago

Description:
Currently, there is no option to configure labels for the ollama service in the values.yaml file. This feature is important for customizing specific configurations for the service and managing them effectively. This issue aims to add this functionality by making labels for the ollama service configurable in the values.yaml file.

Expected Behavior:
It should be possible to configure labels for the ollama service in the values.yaml file to allow flexible customization of the configuration.

Add the following configuration in values.yaml:

ollama:
  service:
    labels:
      my.custom.label: example-label

Use the helm template command to ensure that the configuration has been applied correctly. yq Package is necessary for the following command:

helm template \
    open-webui \
    . \
    -n open-webui \
    -f values.yaml \
  |yq 'select(.kind=="Service")' | yq 'select(.metadata.name=="ollama")'
apiVersion: v1
kind: Service
metadata:
  name: ollama
  labels:
    my.custom.label: example-label
    ...
...

Additional Information:

0xThresh commented 4 months ago

Hey @stepanbaghdasaryan, that looks like a great change to have. I'm curious to get your thoughts in https://github.com/open-webui/helm-charts/issues/5 which proposes to move work away from using our own Ollama templates on this repo, and instead pulling a separate Ollama chart that's more advanced as a dependency to this one.

stepanbaghdasaryan commented 4 months ago

@0xThresh I've posted my opinion in your issue https://github.com/open-webui/helm-charts/issues/5#issuecomment-2099901798, and we can continue discussing it there.

stepanbaghdasaryan commented 4 months ago

No new Helm chart has been built with this change yet; version 1.0.1 is still present in the repository.

0xThresh commented 4 months ago

Looks like we have the 2.x charts deployed now, do those include the fixes you merged in?

robrakaric commented 4 months ago

The move to 2.x removed the Ollama resource definitions, so the addition of labels for Ollama would no longer apply to this chart. Would recommend submitting a PR to https://github.com/otwld/ollama-helm to get service labels added to the Ollama chart itself. After that chart is released, a dependency update and minor version increment would be done on the open-webui chart in order to include the new ollama chart as a dependency.