search

open-webui / helm-charts

53 stars 37 forks source link

render env vars as yaml #21

Closed plenti-chris-fowles closed 4 months ago

plenti-chris-fowles commented 4 months ago

relates to #14

allows use of secrets and config maps as sources for env var values (e.g. OPENAI_API_KEY as a secret)

tjbck commented 4 months ago

@0xThresh review wanted 🙌

0xThresh commented 4 months ago

Thanks for the PR @plenti-chris-fowles, I'll test this out today. Note that if we approve and merge this, you'll need to bump the chart version up before it'll be deployed, so please bump the chart up a version in a new commit.

0xThresh commented 4 months ago

I ran into an issue with this chart and the current version of the chart that I haven't seen before, so I'm going to have to troubleshoot that further before I can test and approve this, sorry for the delay

0xThresh commented 4 months ago

@tjbck I was finally able to test this update out and it's working for me. Below is the result of pulling an env var from a secret by uncommenting the example added to the values.yaml file (OpenAPI key is automatically loaded without having to add it manually):

image

While it looks good, the chart version still needs to be updated in Chart.yaml before we merge this to ensure that the new version is released. @plenti-chris-fowles or @tjbck before merging, can you bump the version in Chart.yaml to v2.1.0 please?

plenti-chris-fowles commented 4 months ago

Hey folks,

Happy to bump the chart version myself - this is usually something that the release management team would take care of however (as I don't have control over the order in which PRs are merged).

I'll bump it now, but you may want to consider a different approach if you start getting more contributions to this repo. <3

tjbck commented 4 months ago

Thanks everyone!