open-y-subprojects / openy_custom

Custom modules from Open Y core. Decoupled for ability to use outside of Open Y when needed.
GNU General Public License v3.0
0 stars 14 forks source link

fix(performance,cache): Allow plugin definitions caching #52

Closed AndreyMaximov closed 11 months ago

AndreyMaximov commented 11 months ago

The custom ContainerFactory assigned upon instantiating the HomeBranch plugin manager disables the plugin definition caching. That leads to a performance issue - Drupal core searches for the plugins each time the plugin is requested.

On one of the websites, the Plugin Discovery during the content indexing could call the file_exists function and annotation reading 50k times for 50 indexed nodes.

Also, the cache backend doesn't need its entries to be tagged with 'node_list', because a change in nodes can't change the plugin definitions.

podarok commented 11 months ago

good catch, thanks