search

open-zaak / open-notificaties

API voor ontvangen en distribueren van notificaties
Other
0 stars 8 forks source link

replace drf-yasg with drf-spectacular #145

Closed annashamray closed 3 months ago

annashamray commented 4 months ago

fixes #139

bart-maykin commented 4 months ago

Screenshot from 2024-05-03 12-06-18

@annashamray It seems that callbacks_create got added with these changes, from what I can tell this isn't intentional or am I wrong about that? In case it is I will keep the pr on approved.

annashamray commented 4 months ago

@bart-maykin this callback endpoint was always in the API, but we haven't displayed it in the OAS with drf-yasg. But I don't think we need to hide it. It doesn't look like we use this endpoint, so I'll remove it

annashamray commented 4 months ago

@bart-maykin update: it looks like this endpoint is being used to update authorizations, so I restored it. But I still don't think we should hide it in the OAS @joeribekker What do you think?

annashamray commented 4 months ago

UPD the callback endpoint is excluded from OAS just like it was before