open-zaak / open-zaak

Open Zaak is a modern, open-source data- and services-layer to enable zaakgericht werken, a Dutch approach to case management.
Other
38 stars 36 forks source link

Add maykin_2fa #1637

Closed stevenbal closed 2 months ago

stevenbal commented 3 months ago

I thought 2FA was already part of Open Zaak and Open Notificaties, but it turns out that was never the case. I think it would be good idea to add that, just like it was added in Objects/Objectypes API

https://maykin-2fa.readthedocs.io/en/stable/

joeribekker commented 3 months ago

Since, this is up... I would really like to add the same construction we did in Open Formulieren: based on the auth backend, use 2fa or not. And ofcourse, add 2fa to OZ and ON :)

For the one pickinf this up, please updated this ticket to reflect what needs to be done in all the projects :)

bart-maykin commented 3 months ago

Since, this is up... I would really like to add the same construction we did in Open Formulieren: based on the auth backend, use 2fa or not. And ofcourse, add 2fa to OZ and ON :)

For the one pickinf this up, please updated this ticket to reflect what needs to be done in all the projects :)

The disabling of 2fa based on auth backend can be done with the library settings MAYKIN_2FA_ALLOW_MFA_BYPASS_BACKENDS within maykin-2fa

joeridiederen commented 1 month ago

Hi @joeribekker; weet je wanneer deze optie in Open Notificaties gaat landen? Ik zie dat dit ticket zowel OZ als ON beschrijft, maar op de ON-backlog vind ik 'm niet terug (https://github.com/open-zaak/open-notificaties/milestones). Alvast dank!

joeribekker commented 1 month ago

@joeridiederen klopt, we merkten dat we steeds tickets kopieerden van component A naar B dus we proberen iets meer te centraliseren maar daardoor zie je het niet direct op de backlog van het component.

joeribekker commented 1 month ago

Het is overigens wel gedaan: https://github.com/open-zaak/open-notificaties/pull/151