open223 / docs.open223.info

ASHRAE 223P User Documentation
https://docs.open223.info/
2 stars 1 forks source link

example to align s223:Sensor with brick:*_Sensor #43

Open VladimirAlexiev opened 2 months ago

VladimirAlexiev commented 2 months ago

https://docs.open223.info/guides/brick-rec.html#using-brick-points-with-223 shows this:

bldg:sensor a s223:Sensor ;
    s223:hasObservationLocation bldg:damper-out ;
    s223:hasPhysicalLocation bldg:damper ;
    s223:observes bldg:air-temp .

bldg:air-temp a s223:QuantifiableObservableProperty,
                brick:Supply_Air_Temperature_Sensor ;
    qudt:hasQuantityKind qudtqk:Temperature ;
    s223:hasAspect s223:Role-Supply ;
    qudt:hasUnit unit:DEG_C .

But why is the s223:QuantifiableObservableProperty instantiated as brick:Supply_Air_Temperature_Sensor? I think that the s223:Sensor should be instantiated as brick:Supply_Air_Temperature_Sensor.

If so, then https://github.com/open223/docs.open223.info/pull/42 also needs to be adjusted.

steveraysteveray commented 2 months ago

I agree with @VladimirAlexiev, although I think he meant to say that bldg:sensor should be instantiated as brick:Supply_Air_Temperature_Sensor, not the class s223:Sensor.

VladimirAlexiev commented 2 months ago

By "the property" and "the sensor" I mean instances of these respective classes