search

open229 / ruleset-model-description-schema

Developing a schema for ASHRAE Standard 229P.
Other
7 stars 3 forks source link

Clarify the units and range for 'maximum humidity setpoint' input #116

Closed supriyagoel closed 2 years ago

supriyagoel commented 2 years ago

The input for maximum humidity setpoint needs units/range values to clarify that this is a fraction between 0-1 and is unitless or a %.

image

image

JasonGlazer commented 2 years ago

@supriyagoel I'm confused by what you want changed based on the image that you pasted. It doesn't seem to show any differences. Could you please elaborate?

JasonGlazer commented 2 years ago

@supriyagoel I made the following change:

minimum_humidity_setpoint_schedule:
  Description: "Reference to the schedule containing the minimum relative humidity setpoint"
  Data Type: "Reference"
  Range: ">=0, <=1"
  Notes: "For schedule values use relative humidity expressed on a 0 to 1 scale. Constraint to use when implemented :Schedule:"
maximum_humidity_setpoint_schedule:
  Description: "Reference to the schedule containing the maximum relative humidity setpoint"
  Data Type: "Reference"
  Range: ">=0, <=1"
  Notes: "For schedule values use relative humidity expressed on a 0 to 1 scale. Constraint to use when implemented :Schedule:"

I don't have a unit called "unitless" and I am not sure it would add any value.

I am also not sure that having a range on a reference to a schedule will translate into validating that the values of the schedule are within the range.

JasonGlazer commented 2 years ago

Addressed in 0.0.18

supriyagoel commented 2 years ago

Thanks @JasonGlazer, the changes look good. Good to know that we don't have a way to identify a unitless parameter. The range is helpful to include