open229 / ruleset-model-description-schema

Developing a schema for ASHRAE Standard 229P.
Other
9 stars 3 forks source link

Add notes to Terminal, HeatingSystem, and CoolingSystem, remove BASEBOARD from HeatingSystemOptions, remove TerminalOptions to clarify systems #127

Closed JasonGlazer closed 2 years ago

JasonGlazer commented 2 years ago

Some system configurations could be described either using the Terminal data group or by using the HeatingSystem and CoolingSystem data groups. To eliminate the possibility of the same system configurations being described in two different ways, notes will be added to:

The note will state:

"System configurations that typically are at the zone and include a compressor (such as packaged terminal air conditioning, packaged terminal heat pumps, window air conditioning units, and water loop heat pumps) shall be modeled using HeatingSystem and CoolingSystem. System configurations that are at the zone and only include fans and coils (such as four0pipe fan coil, two-pipe fan coil, radiant systems, baseboards, and chilled beams) shall be modeled using Terminal."

To be consistent with this, the BASEBOARD enumeration option in HeatingSystemOptions will be removed.

The FOUR_PIPE_FAN_COIL_UNIT and TWO_PIPE_FAN_COIL_UNIT enumeration options will be removed from TerminalOptions since those will be determined by interpreting the configuration like all other system configurations and did not allow the simultaneous specification of VARIABLE_AIR_VOLUME or CONSTANT_AIR_VOLUME to be applied to fan coil configurations.

mkarpman commented 2 years ago

Looks great to me, thank you!

JasonGlazer commented 2 years ago

Addressed in 0.0.20 update