search

open229 / ruleset-model-description-schema

Developing a schema for ASHRAE Standard 229P.
Other
9 stars 3 forks source link

Incorrect units on pump_power_per_flow_rate #132

Closed jugonzal07 closed 2 years ago

jugonzal07 commented 2 years ago

I believe that, dimensionally, the units are incorrect on this parameter. https://github.com/open229/ruleset-model-description-schema/blob/master/docs229/ASHRAE229.schema.json#L2862

The units read W/s-L but I imagine this was meant to be W-s/L perhaps? That would agree dimensionally with a W/gpm in IP units.

JasonGlazer commented 2 years ago

Thanks @jugonzal07 this will be addressed in the 0.0.21 update