search

open229 / ruleset-model-description-schema

Developing a schema for ASHRAE Standard 229P.
Other
7 stars 3 forks source link

Review enumeration data element names and enumeration names for consistency #177

Closed nealkruis closed 1 year ago

nealkruis commented 1 year ago

Many enumeration names end with "Option", but others use "Type". Standard 205 and 232P both recommend using "Type" for consistency.

JasonGlazer commented 1 year ago

@nealkruis I had previously updated all the enumerations to use "Option" so please let me know if you still see any that use "Type", they should not. I think Options is actually a much better descriptor than Type which is much more generic and seems unrelated to it being an enumeration. Perhaps 205 and 232P should reconsider :-)

I am leaning toward not addressing this issue.

JasonGlazer commented 1 year ago

I just reviewed all enumerations again and they all consistently use the term "Options". If you want to make the case for "type" please open a new issue.