search

open229 / ruleset-model-description-schema

Developing a schema for ASHRAE Standard 229P.
Other
7 stars 3 forks source link

Move data groups that are under RulesetModelInstance #186

Closed JasonGlazer closed 11 months ago

JasonGlazer commented 1 year ago

Several data groups under RulesetModelInstance are there only because they are used everywhere else in the schema by a reference to an ID only. Perhaps a new data group called "DatagroupsReferencedByID" or "OnlyReferencedByID" should be added.

This change may not be worth the effort at this point since it would have significant programming effort. What do you think @weilixu ?

weilixu commented 1 year ago

I agree. Currently RCT has a way to find those data groups by their ID. Adding the new data group does not change the outcome but requires a lot rework.

JasonGlazer commented 11 months ago

@weilixu I am closing this as Wont Fix.