Closed hisakatha closed 1 year ago
Hello. I have found that an argument expected_value_col in PileUpper methods (__init__ constructor and pileup) is ignored. For example, the argument is ignored as follows, which does not satisfy the description of the pileup method.
expected_value_col
__init__
pileup
https://github.com/open2c/coolpuppy/blob/57426dd811f712afb54b076323726e8ead7ff0c8/coolpuppy/coolpup.py#L2128
I have fixed the codes and going to make a pull request soon.
Hello. I have found that an argument
expected_value_col
in PileUpper methods (__init__
constructor andpileup
) is ignored. For example, the argument is ignored as follows, which does not satisfy the description of thepileup
method.https://github.com/open2c/coolpuppy/blob/57426dd811f712afb54b076323726e8ead7ff0c8/coolpuppy/coolpup.py#L2128
I have fixed the codes and going to make a pull request soon.