open2c / coolpuppy

A versatile tool to perform pile-up analysis on Hi-C data in .cool format.
MIT License
77 stars 11 forks source link

Argument `expected_value_col` in PileUpper methods is ignored #126

Closed hisakatha closed 1 year ago

hisakatha commented 1 year ago

Hello. I have found that an argument expected_value_col in PileUpper methods (__init__ constructor and pileup) is ignored. For example, the argument is ignored as follows, which does not satisfy the description of the pileup method.

https://github.com/open2c/coolpuppy/blob/57426dd811f712afb54b076323726e8ead7ff0c8/coolpuppy/coolpup.py#L2128

I have fixed the codes and going to make a pull request soon.