search

open2c / coolpuppy

A versatile tool to perform pile-up analysis on Hi-C data in .cool format.
MIT License
77 stars 11 forks source link

Added ignore_group_order argument #130

Closed efriman closed 1 year ago

efriman commented 1 year ago

Changed how flip_negative_strand is implemented Added ignore_group_order argument, which combines groups (e.g. group1-group2 and group2-group1) Changed how coordinates are added when using store_stripes Fixed rescaling with zeros Added error msgs Updated walkthroughs Added test for stripes and ignorer_group_order Fixed Readthedocs error with urllib3 Fixed misnamed rows/cols info in plotpup.py Changed divide_pups to not error when columns are non-identical, warn instead

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

Phlya commented on 2023-07-04T14:43:16Z ----------------------------------------------------------------

Can you rerun with a bigger subset to make it a bit smoother?


efriman commented on 2023-07-10T12:03:55Z ----------------------------------------------------------------

Done

Phlya commented on 2023-07-10T14:06:51Z ----------------------------------------------------------------

Very nice, thanks!

efriman commented 1 year ago

Done

View entire conversation on ReviewNB

Phlya commented 1 year ago

Very nice, thanks!

View entire conversation on ReviewNB

Phlya commented 1 year ago

Can you add a test for ignore_group_order argument? Otherwise looks good to me, thank you!

efriman commented 1 year ago

Can you add a test for ignore_group_order argument? Otherwise looks good to me, thank you!

Done :)

Phlya commented 1 year ago

Fantastic, I think it's ready to merge, do you have anything else to add here or is it done from your side?

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.