search

open2c / cooltools

The tools for your .cool's
MIT License
140 stars 51 forks source link

Possible bug in insulation? #523

Closed gdolsten closed 5 months ago

gdolsten commented 5 months ago

in api.py, annotate, should this line:

        anns.append(
            ann2.iloc[bin2 - bmin]
            .rename(columns=lambda x: x + "2")
            .reset_index(drop=True)
        )

be:


        anns.append(
            ann2.loc[bin2 - bmin]
            .rename(columns=lambda x: x + "2")
            .reset_index(drop=True)
        )

?

Phlya commented 5 months ago

https://github.com/open2c/cooler/pull/422 is this what you mean? In cooler.annotate?

gdolsten commented 5 months ago

Yes, sorry. I just realized that the bug was in cooler and not in cooltools. On my current install, calling insulation scores is broken.

Phlya commented 5 months ago

Ok, thank you for reporting. As a temporary fix, you can downgrade cooler to 0.9.3