search

open2c / open2c_examples

16 stars 9 forks source link

add simplified dots notebook #22

Closed sergpolly closed 2 years ago

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

gfudenberg commented 2 years ago

This looks like a great start!

I'd also add some overview of the approach where dots() is first called, e.g. along the lines of the docstring https://github.com/open2c/cooltools/blob/45a56dfd07b8058b908763cc7c8e7db3fc52875e/cooltools/api/dotfinder.py#L26 (though perhaps streamlined a bit)

sergpolly commented 2 years ago

gfudenberg I added that description in the beginning of the notebook - would appreciate if you could help me iron out the text

I've also changed the description near the discussion about kernels - could you please check that one out as well ?

do you think we could merge it once that's done ? I'll figure out CTCF-related stuff after that

gfudenberg commented 2 years ago

looks great! merged!