open2c / pairtools

Extract 3D contacts (.pairs) from sequencing alignments
MIT License
104 stars 32 forks source link

list index out of range error on line 574 of pairtools_parse.py #77

Closed nkschaefer closed 5 years ago

nkschaefer commented 5 years ago

Hi,

I'm not an expert on the code, but I'm getting a fatal list index out of range error thrown by the parse_sams_into_pair function in pairtools_parse.py (line 574) -- the cause looks like trying to access the first element in algns1 and algns2, but my algns2 is empty in this case. I haven't dug deep enough to know if this is due to a problem with my BAM file and how it was generated, or whether the program should check for and handle this (or print some kind of error message).

I tried adding a check that len(sams1) > 0 and len(sams2) > 0 on line 782, in streaming_classify, and this lets the program run without the error. No idea if this will cause any other problems downstream, though.

Thanks for any help you can provide.

--Nathan

nkschaefer commented 5 years ago

It looks like this was a problem with how the data were generated upstream.

golobor commented 5 years ago

apologies for not answering earlier - I've been busy moving my family across continents. Glad to hear that it got resolved!

On Tue, 24 Sep 2019 at 23:30, nkschaefer notifications@github.com wrote:

Closed #77 https://github.com/mirnylab/pairtools/issues/77.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mirnylab/pairtools/issues/77?email_source=notifications&email_token=AAG64CRK5ARLZE6ASDDO7GDQLKBF7A5CNFSM4IOPXGY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT2DGYEY#event-2659609619, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG64CUD4Y2MVDLPN2XROPLQLKBF7ANCNFSM4IOPXGYQ .