search

open2jamorg / open2jam

open source o2jam emulator
open2jam.wordpress.com
Artistic License 2.0
109 stars 40 forks source link

Release notes in autoplay lane #13

Closed keigen-shu closed 12 years ago

keigen-shu commented 12 years ago

There are cases where a long note's release can end up in the autoplay lanes. Try playing Brahms(O2 Remix)+ on HX. You can hear the double keysounds just as if they were long notes. I guess it surfaced beause Beautiful Day was a lazy notecharter (and mixer) and the NoteTool was just recently upgraded then to support long notes and had this design error.

Fix:

else if (type == 3 && channel != Event.Channel.AUTO_PLAY) {
    event_list.add(new Event(channel, measure, position, value, Event.Flag.RELEASE, volume, pan));
}
chaosfox commented 12 years ago

OH that's it !

I always noticed that but never realized the problem !, thanks.

mrcdk commented 12 years ago

Omg, I forgot about this xD I think it's fixed now right?