open2jamorg / open2jam

open source o2jam emulator
open2jam.wordpress.com
Artistic License 2.0
109 stars 40 forks source link

Keyboard handling does not work on Mac #5

Closed dtinth closed 13 years ago

dtinth commented 13 years ago

On Mac OS X, open2jam seems to not be able to handle any key presses, instead, the program freezes.

It does not crash, it just doesn't respond to user events anymore.

For example, when playing a song, the notes will drop just fine, but you can't press any keys. You can't close the window either. The same also happens on keyboard configuration screen, after you click on a row and a dialog box pops up, the app freezes too.

mrcdk commented 13 years ago

Well, that will be pretty hard to fix because I think none of us have a mac xD Last time open2jam was tested on one the only problem was that it wasn't handling the esc key but other things were ok :/ And as far as i know the keyboard handling hasn't being touched after that.

chaosfox commented 13 years ago

@dtinth Is this a regression ? I mean, this is the first time you are testing or did it worked in previous versions ?

Edit: this is probably the problem http://lwjgl.org/forum/index.php/topic,3660.0.html

dtinth commented 13 years ago

It didn't work since the first time I tried it on Mac OS X, and that was since alpha 5.

And yes the third post in that link does make sense.

chaosfox commented 13 years ago

I made the render execute on a separate thread on branch keyboard_mac, now we need to test it somehow, if I make you a build can you test it ?

dtinth commented 13 years ago

Yes. That would be very convenient for me.

I'm actually trying to download NetBeans here, but that's gonna take some time, so a build would be cool :D.

chaosfox commented 13 years ago

here: https://github.com/downloads/chaosfox/open2jam/open2jam_keyboardmac.zip thats only the jar actually, just replace with the other one, the rest doesn't change.

dtinth commented 13 years ago

Yes, it works. Awesome!

Thanks. :)

chaosfox commented 13 years ago

Solved then ! thank you for reporting the bug.