search

open62541 / open62541-nodeset-loader

Library for loading opc ua nodesets from xml and sorting the nodes
Mozilla Public License 2.0
27 stars 23 forks source link

Parsing of MinimumSamplingInterval attribute is missing #245

Open matkonnerth opened 11 months ago

matkonnerth commented 11 months ago

Nodeset schema defines a MinimumSamplingInterval attribute for UAVariable

piperoc commented 7 months ago

I added and tested the MinimumSamplingAttribute for UAVariable.

You can check my modifications in my fork piperoc/open62541-nodeset-loader . Look for the branch add-minSamplingInterval .

not sure you wanted me to use PR's or so, therefore I figured I'd fork it.

Please double check: I tested with a few nodesets. Some nodesets give me troubles in general (for example, the euromap ones are weird for me).

matkonnerth commented 7 months ago

thank you, I've create a PR from your work.

Which euromap nodesets generate troubles?

matkonnerth commented 7 months ago

looks good, merged it to master.

piperoc commented 7 months ago

thank you, I've create a PR from your work.

Which euromap nodesets generate troubles?

Thank you @matkonnerth . I haven't tested extensively, but here's an error I get all the time with the following:

image

Could it be due to the UAModeler extensions?

matkonnerth commented 7 months ago

seems that there is a circle with hierachical references between some nodes (node1 -> node2 ->node1), can you provide me the nodeset?

piperoc commented 7 months ago

Sure @matkonnerth, the nodeset I used is the one in open62541-nodeset-loader/nodesets/euromap_instances/euromapinstances.xml .

I think UANodesets may contain loops (as a directed multigraph)...