ccmake : Subscription Events caused segmentation fault in UA_Server_addVariableNode() function

jackybek commented 3 years ago

Description

Background Information / Reproduction Steps

if i choose UA_ENABLE_SUBSCRIPTIONS_ALARMS and UA_ENABLE_SUBSCRIPTIONS_EVENTS, set the UA_NAMESPACE_ZERO to FULL and recompile my code, during runtime, UA_Server_addVariableNode caused segmentation fault.

In order to prove that it is caused by these 2 settings, i reverted back to:

UA_ENABLE_SUBSCRIPTIONS_ALARMS = OFF
UA_ENABLE_SUBSCRIPTIONS_EVENTS = OFF
UA_ENABLE_SUBSCRIPTIONS_EVENTS = reduced

and my program execute without errors.

Used CMake options:

BIBER_COMPILER:FILEPATH=BIBER_COMPILER-NOTFOUND BIBTEX_COMPILER:FILEPATH=BIBTEX_COMPILER-NOTFOUND BUILD_SHARED_LIBS:BOOL=OFF CLANG_FORMAT_EXE:FILEPATH=CLANG_FORMAT_EXE-NOTFOUND CLANG_FORMAT_PROGRAM:FILEPATH=CLANG_FORMAT_PROGRAM-NOTFOUND CLANG_TIDY_PROGRAM:FILEPATH=CLANG_TIDY_PROGRAM-NOTFOUND CMAKE_AR:FILEPATH=/usr/bin/ar CMAKE_BUILD_TYPE:STRING=Debug CMAKE_COLOR_MAKEFILE:BOOL=ON CMAKE_C_COMPILER:FILEPATH=/usr/bin/cc CMAKE_C_COMPILER_AR:FILEPATH=/usr/bin/gcc-ar-8 CMAKE_C_COMPILER_RANLIB:FILEPATH=/usr/bin/gcc-ranlib-8 CMAKE_C_FLAGS:STRING= CMAKE_C_FLAGS_DEBUG:STRING=-g CMAKE_C_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG CMAKE_C_FLAGS_RELEASE:STRING=-O3 -DNDEBUG CMAKE_C_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG CMAKE_EXE_LINKER_FLAGS:STRING= CMAKE_EXE_LINKER_FLAGS_DEBUG:STRING= CMAKE_EXE_LINKER_FLAGS_MINSIZEREL:STRING= CMAKE_EXE_LINKER_FLAGS_RELEASE:STRING= CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO:STRING= CMAKE_EXPORT_COMPILE_COMMANDS:BOOL=OFF CMAKE_INSTALL_BINDIR:PATH=bin CMAKE_INSTALL_DATADIR:PATH= CMAKE_INSTALL_DATAROOTDIR:PATH=share CMAKE_INSTALL_DOCDIR:PATH= CMAKE_INSTALL_INCLUDEDIR:PATH=include CMAKE_INSTALL_INFODIR:PATH= CMAKE_INSTALL_LIBDIR:PATH=lib CMAKE_INSTALL_LIBEXECDIR:PATH=libexec CMAKE_INSTALL_LOCALEDIR:PATH= CMAKE_INSTALL_LOCALSTATEDIR:PATH=var CMAKE_INSTALL_MANDIR:PATH= CMAKE_INSTALL_OLDINCLUDEDIR:PATH=/usr/include CMAKE_INSTALL_PREFIX:PATH=/usr/local CMAKE_INSTALL_RUNSTATEDIR:PATH= CMAKE_INSTALL_SBINDIR:PATH=sbin CMAKE_INSTALL_SHAREDSTATEDIR:PATH=com CMAKE_INSTALL_SYSCONFDIR:PATH=etc CMAKE_LINKER:FILEPATH=/usr/bin/ld CMAKE_MAKE_PROGRAM:FILEPATH=/usr/bin/make CMAKE_MODULE_LINKER_FLAGS:STRING= CMAKE_MODULE_LINKER_FLAGS_DEBUG:STRING= CMAKE_MODULE_LINKER_FLAGS_MINSIZEREL:STRING= CMAKE_MODULE_LINKER_FLAGS_RELEASE:STRING= CMAKE_MODULE_LINKER_FLAGS_RELWITHDEBINFO:STRING= CMAKE_NM:FILEPATH=/usr/bin/nm CMAKE_OBJCOPY:FILEPATH=/usr/bin/objcopy CMAKE_OBJDUMP:FILEPATH=/usr/bin/objdump CMAKE_RANLIB:FILEPATH=/usr/bin/ranlib CMAKE_SHARED_LINKER_FLAGS:STRING= CMAKE_SHARED_LINKER_FLAGS_DEBUG:STRING= CMAKE_SHARED_LINKER_FLAGS_MINSIZEREL:STRING= CMAKE_SHARED_LINKER_FLAGS_RELEASE:STRING= CMAKE_SHARED_LINKER_FLAGS_RELWITHDEBINFO:STRING= CMAKE_SKIP_INSTALL_RPATH:BOOL=NO CMAKE_SKIP_RPATH:BOOL=NO CMAKE_STATIC_LINKER_FLAGS:STRING= CMAKE_STATIC_LINKER_FLAGS_DEBUG:STRING= CMAKE_STATIC_LINKER_FLAGS_MINSIZEREL:STRING= CMAKE_STATIC_LINKER_FLAGS_RELEASE:STRING= CMAKE_STATIC_LINKER_FLAGS_RELWITHDEBINFO:STRING= CMAKE_STRIP:FILEPATH=/usr/bin/strip CMAKE_VERBOSE_MAKEFILE:BOOL=FALSE CPACK_SOURCE_RPM:BOOL=OFF CPACK_SOURCE_TBZ2:BOOL=ON CPACK_SOURCE_TGZ:BOOL=ON CPACK_SOURCE_TXZ:BOOL=ON CPACK_SOURCE_TZ:BOOL=ON CPACK_SOURCE_ZIP:BOOL=OFF DVIPDF_CONVERTER:FILEPATH=/usr/bin/dvipdf DVIPS_CONVERTER:FILEPATH=DVIPS_CONVERTER-NOTFOUND GIT_EXECUTABLE:FILEPATH=/usr/bin/git HTLATEX_COMPILER:FILEPATH=HTLATEX_COMPILER-NOTFOUND LATEX2HTML_CONVERTER:FILEPATH=LATEX2HTML_CONVERTER-NOTFOUND LATEX_COMPILER:FILEPATH=LATEX_COMPILER-NOTFOUND LUALATEX_COMPILER:FILEPATH=LUALATEX_COMPILER-NOTFOUND MAKEINDEX_COMPILER:FILEPATH=MAKEINDEX_COMPILER-NOTFOUND MDNSD_LOGLEVEL:STRING=300 OPENSSL_CRYPTO_LIBRARY:FILEPATH=/usr/local/ssl/lib/libcrypto.so OPENSSL_INCLUDE_DIR:PATH=/usr/local/ssl/include OPENSSL_SSL_LIBRARY:FILEPATH=/usr/local/ssl/lib/libssl.so PDFLATEX_COMPILER:FILEPATH=PDFLATEX_COMPILER-NOTFOUND PDFTOPS_CONVERTER:FILEPATH=/usr/bin/pdftops PKG_CONFIG_EXECUTABLE:FILEPATH=/usr/bin/pkg-config PS2PDF_CONVERTER:FILEPATH=/usr/bin/ps2pdf14 PYTHON_EXECUTABLE:FILEPATH=/usr/bin/python SPHINX_EXECUTABLE:FILEPATH=/usr/bin/sphinx-build UA_AMALGAMATION_ARCHITECTURES:STRING= UA_ARCHITECTURE:STRING=posix UA_ARCH_ADD_FLAGS:STRING= UA_ARCH_EXTRA_INCLUDES:STRING= UA_ARCH_LINKER_FLAGS:STRING= UA_ARCH_REMOVE_FLAGS:STRING= UA_BUILD_EXAMPLES:BOOL=OFF UA_BUILD_FUZZING:BOOL=OFF UA_BUILD_FUZZING_CORPUS:BOOL=OFF UA_BUILD_OSS_FUZZ:BOOL=OFF UA_BUILD_TOOLS:BOOL=OFF UA_BUILD_UNIT_TESTS:BOOL=OFF UA_DEBUG:BOOL=OFF UA_DEBUG_DUMP_PKGS:BOOL=OFF UA_ENABLE_AMALGAMATION:BOOL=ON UA_ENABLE_CLANG_COV:BOOL=OFF UA_ENABLE_COVERAGE:BOOL=OFF UA_ENABLE_DA:BOOL=ON UA_ENABLE_DETERMINISTIC_RNG:BOOL=OFF UA_ENABLE_DISCOVERY:BOOL=ON UA_ENABLE_DISCOVERY_MULTICAST:BOOL=OFF UA_ENABLE_DISCOVERY_SEMAPHORE:BOOL=OFF UA_ENABLE_ENCRYPTION:BOOL=ON UA_ENABLE_ENCRYPTION_MBEDTLS:BOOL=OFF UA_ENABLE_ENCRYPTION_OPENSSL:BOOL=ON UA_ENABLE_EXPERIMENTAL_HISTORIZING:BOOL=OFF UA_ENABLE_HARDENING:BOOL=ON UA_ENABLE_HISTORIZING:BOOL=ON UA_ENABLE_IMMUTABLE_NODES:BOOL=OFF UA_ENABLE_JSON_ENCODING:BOOL=ON UA_ENABLE_MALLOC_SINGLETON:BOOL=OFF UA_ENABLE_METHODCALLS:BOOL=ON UA_ENABLE_MICRO_EMB_DEV_PROFILE:BOOL=OFF UA_ENABLE_NODEMANAGEMENT:BOOL=ON UA_ENABLE_NODESET_COMPILER_DESCRIPTIONS:BOOL=ON UA_ENABLE_PARSING:BOOL=ON UA_ENABLE_PUBSUB:BOOL=ON UA_ENABLE_PUBSUB_DELTAFRAMES:BOOL=ON UA_ENABLE_PUBSUB_ETH_UADP:BOOL=ON UA_ENABLE_PUBSUB_ETH_UADP_XDP:BOOL=OFF UA_ENABLE_PUBSUB_FILE_CONFIG:BOOL=OFF UA_ENABLE_PUBSUB_INFORMATIONMODEL:BOOL=ON UA_ENABLE_PUBSUB_INFORMATIONMODEL_METHODS:BOOL=ON UA_ENABLE_PUBSUB_MONITORING:BOOL=ON UA_ENABLE_PUBSUB_MQTT:BOOL=ON UA_ENABLE_QUERY:BOOL=OFF UA_ENABLE_STATIC_ANALYZER:STRING=OFF UA_ENABLE_STATUSCODE_DESCRIPTIONS:BOOL=ON UA_ENABLE_SUBSCRIPTIONS:BOOL=ON UA_ENABLE_SUBSCRIPTIONS_ALARMS_CONDITIONS:BOOL=OFF UA_ENABLE_SUBSCRIPTIONS_EVENTS:BOOL=OFF UA_ENABLE_TYPEDESCRIPTION:BOOL=ON UA_ENABLE_UNIT_TESTS_MEMCHECK:BOOL=OFF UA_ENABLE_UNIT_TEST_FAILURE_HOOKS:BOOL=OFF UA_ENABLE_VALGRIND_INTERACTIVE:BOOL=OFF UA_ENABLE_WEBSOCKET_SERVER:BOOL=OFF UA_FILE_NS0:BOOL=OFF UA_FILE_NS0_BLACKLIST:BOOL=OFF UA_FORCE_32BIT:BOOL=OFF UA_FORCE_CPP:BOOL=OFF UA_LOGLEVEL:STRING=300 UA_MSVC_FORCE_STATIC_CRT:BOOL=ON UA_MULTITHREADING:STRING=0 UA_NAMESPACE_ZERO:STRING=REDUCED UA_PACK_DEBIAN:BOOL=OFF UA_VALGRIND_INTERACTIVE_INTERVAL:STRING=1000 XELATEX_COMPILER:FILEPATH=XELATEX_COMPILER-NOTFOUND XINDY_COMPILER:FILEPATH=XINDY_COMPILER-NOTFOUND

cmake -DUA_NAMESPACE_ZERO=<YOUR_OPTION> <ANY_OTHER_OPTIONS> ..

Checklist

Please provide the following information:

[X] open62541 Version (release number or git tag): "v1.2-rc2-61-g0af95df8"
[ ] Other OPC UA SDKs used (client or server):
[X] Operating system: Raspian OS
[ ] Logs (with UA_LOGLEVEL set as low as necessary) attached
[ ] Wireshark network dump attached

[X] Self-contained code example attached

UA_VariableAttributes vSoftwareVersionAttr = UA_VariableAttributes_default;
vSoftwareVersionAttr.description = UA_LOCALIZEDTEXT("en-US", "Software Version Info");
vSoftwareVersionAttr.displayName = UA_LOCALIZEDTEXT("en-US", "1. Software Version");
vSoftwareVersionAttr.accessLevel = UA_ACCESSLEVELMASK_READ | UA_ACCESSLEVELMASK_WRITE;
UA_String SoftwareVersion[255];
UA_Variant_setArray(&vSoftwareVersionAttr.value, &SoftwareVersion, 255, &UA_TYPES[UA_TYPES_STRING]);
UA_Server_addVariableNode(uaServer, UA_NODEID_NUMERIC(1, 10001),                // NodeId
    r1_airgardroot_Id,                          // parent NodeId
    UA_NODEID_NUMERIC(0, UA_NS0ID_HASPROPERTY), // parent Reference NodeId
    UA_QUALIFIEDNAME(1, "Software Version"),    // Qualified Name
    UA_NODEID_NUMERIC(0, UA_NS0ID_BASEDATAVARIABLETYPE),
    vSoftwareVersionAttr, NULL, &outSoftwareVersion_Id);

[X] Critical issue

jackybek commented 3 years ago

UA_NAMESPACE_ZERO = reduced

I checked the open62541 documentation and came across this requirement:

UA_NAMESPACE_ZERO The advanced build option UA_FILE_NS0 can be used to override the XML file used for namespace zero generation.

so i enable UA_FILE_NS0=ON. But during compilation, i get this error message:

CMake Error at CMakeLists.txt:1005 (message): File ON not found. You probably need to initialize the git submodule for deps/ua-nodeset or set open62541_NODESET_DIR.

Can I know how to go about

'initialising the git submodule for deps/ua-nodeset' OR
set open62541_NODESET_DIR = some directory

For option 2, where can i find nodeset2.xml?

jackybek commented 3 years ago

ok. I found how to do item 1 and 2. item 1 - cd open62541; git submodule_update --init --recursive

item 2 - export open6541_NODESET_DIR="/home/pi/open62541/deps/ua_nodeset/Schema/" env (to verify)

then I perform : ccmake .. , followed by c,g, then make After which i build my code. During execution, i still get the same error.

Can anyone advise if have successfully include 'Subscription_events" option in ccmake, and compile the sample code in github? Thanks.

jackybek commented 3 years ago

Resolved.. errors due to invalid white spaces in open62541.c and open62541.h

open62541 / open62541