open768 / spaceinc

chicken katsu useful space routines
0 stars 0 forks source link

update manifest database when retrieving manifests #13

Closed open768 closed 1 month ago

open768 commented 1 month ago

currently manifests are loaded by cacheing data from JPL. now that manifests are indexed https://github.com/open768/spaceinc/issues/3 this data structure should be used in preference

open768 commented 1 month ago

at present calls are made to getAllSolData($psSol) which in-turn calls cCuriosityManifest::getAllSolData which caches the JPL data for the sol.

in moving to the manifest index there is the risk that the sol data has been updated, and as only the last 10 sols are updated the updates could be missed. there is a date_added column that is in the NASA feed, we could catch that by storing that in our object database and updating the data as as batch task if it has been been updated.

open768 commented 1 month ago

the date_added issue has been resolved in 1e3a99a69eada030df047b789c66f30ea782ffcd. code checks whether sol data has been updated since it was last stored

open768 commented 1 month ago

currently code uses cCuriosity::getAllSolData( to get the data for a Sol.

this needs to switch to using cCuriosityManifestIndex::getSolData() #17 which would check if it has the sol information and reindex the sol if it doesnt have it.

open768 commented 1 month ago

17 is closed, #19 opened which relates to this

open768 commented 1 month ago

yes this is in the checks now :-) done in #19