openAIP / openaip

Public issue tracker of www.openaip.net.
39 stars 3 forks source link

Multiple misplaced reporting points #279

Closed reskume closed 1 year ago

reskume commented 1 year ago

Issue received via email:

I was cross checking some reporting point coordinates and it seems to me that some reporting point were misplaced.

For example, the Australian file au_rpp.json includes points from Sweden (coordinates Lat 66, Lon 20). There are about 10 such points, all pointing to North Europe.

There are similar problems for Morocco (some points are Sweden), United Kingdom (some points are German), the US (points to German, Sweden, Norway), South Africa (points to some eastern Europe coordinates).

Most of these points are duplicates (or very similar points). This was not a very strict cross check. So, I think there are more problems.

I can probably assemble a test which checks all points against a country polygon. Probably not for all, but perhaps for most and I can find a list of "_id"s off all such points. Would be this helpful for you?

Here is an example from australian file au_rpp.json: Points to Spain,

{"_id":"629cc205f4b4089a578e0f33","approved":true,"name":"NMADR","compulsory":false,"country":"AU","airports":["626143391e911989f7b31a23"],"geometry":{"type":"Point","coordinates":[-3.8791666666666664,40.4045]},"elevation":{"value":678,"unit":0,"referenceDatum":1},"remarks":"Madrid/Cuatro Vientos (Helicopter) VRP - N {NMADR}","createdAt":"2022-06-05T14:47:33.887Z","updatedAt":"2022-06-05T18:04:56.481Z","createdBy":"openaip-system","updatedBy":"OPONcQnzWGOLiJSceNaf8pvx1fA2","elevationGeoid":{"geoidHeight":51.7866822,"hae":729.7866822}}

and another one points to Sweden

{"_id":"629ccd62f4b4089a578e67b8","approved":true,"name":"NORTH","compulsory":false,"country":"AU","airports":["62614315f2228b5341bedbba"],"geometry":{"type":"Point","coordinates":[19.9525,66.03805555555556]},"elevation":{"value":200,"unit":0,"referenceDatum":1},"remarks":"VRP","createdAt":"2022-06-05T15:36:02.815Z","updatedAt":"2022-06-05T20:17:56.516Z","createdBy":"openaip-system","updatedBy":"OPONcQnzWGOLiJSceNaf8pvx1fA2","elevationGeoid":{"geoidHeight":27.625977300000017,"hae":227.62597730000002}}

reskume commented 1 year ago

Set correct country for specified coordinates. Also removed duplicates.