search

openAVproductions / openAV-ArtyFX

A repository for the ArtyFX plugin bundle
GNU General Public License v2.0
80 stars 19 forks source link

makes the benchmark binary optional, but defaults to on #37

Closed Skrylar closed 4 years ago

Skrylar commented 4 years ago

Uses meson's compile options to allow building the plugin on systems that do not have or need the benchmark.

To preserve upstream's existing workflow, the setting defaults to behave the same as before this patch.

meson .. -Dbenchmark=false will however disable the dependency check and attempt to build the bench.

harryhaaren commented 4 years ago

I think I'd prefer just building the benchmark if the dep is present, and otherwise not building it. There's no need for a build-time option here?

If packagers build without the dep available, it won't build benchmark binary.. and if it is present, it will build but not install - both ok, and no user input/config required?

I can do that as a commit, or if you'd prefer update this commit to work with a branch over bench_dep.found() then that's cool with me too?

Skrylar commented 4 years ago

Ok.

harryhaaren commented 4 years ago

Hi, I've squashed your commits and made minor changes to the code; I've kept your commit details. Would you review this branch/commit/PR, and I'll merge if you're OK with it? https://github.com/openAVproductions/openAV-ArtyFX/pull/38

harryhaaren commented 4 years ago

Closing, as has been fixed in https://github.com/openAVproductions/openAV-ArtyFX/pull/38. Thanks @Skrylar for reporting, sending PR and reviewing!