CMake setup hardcodes CFLAGS, CXXFLAGS and LDFLAGS

openAVproductions / openAV-ArtyFX

A repository for the ArtyFX plugin bundle

GNU General Public License v2.0

80 stars 19 forks source link

CMake setup hardcodes CFLAGS, CXXFLAGS and LDFLAGS #42

Closed dvzrv closed 4 years ago

dvzrv commented 4 years ago

Due to the hardcoding of CMAKE_SHARED_LINKER_FLAGS, CMAKE_C_FLAGS and CMAKE_CXX_FLAGS in CMakeLists.txt external $CFLAGS, $CXXFLAGS and $LDFLAGS are not considered (see upstream documentation for CFLAGS and LDFLAGS).

This is not great, as e.g. the resulting shared objects can not be set to have full RELRO without hacking the CMakeList.txt.

dvzrv commented 4 years ago

I see that this is already fixed in 5de759f3. @harryhaaren please release a new version of this plugin!

harryhaaren commented 4 years ago

Before releasing, I'd like to test a few things myself over the weekend, will try get a release out within a few days. Cheers for the ping on this.

harryhaaren commented 4 years ago

Closing this as its fixed already. Rolling release still planned for soon.

dvzrv commented 4 years ago

On 2020-05-08 15:39:47 (-0700), Harry van Haaren wrote:

Closed #42.

Thanks! But can't you close this once you have tagged a new release? No distribution packages HEAD in official repositories (to my knowledge) and the latest tarball that could be used from this repository has this issue.