Make MIDI note-off events trigger release

openAVproductions / openAV-Fabla

A sampler LV2 plugin called Fabla

GNU General Public License v2.0

46 stars 12 forks source link

Make MIDI note-off events trigger release #41

Closed raboof closed 6 years ago

raboof commented 9 years ago

Note that this does mean when 2 voices are playing the same note/sample, and a note-off is received for that note, both voices will decay. This appears to be what the original code intended, but wouldn't you really want only the oldest voice to be released?

raboof commented 8 years ago

@harryhaaren this is now my oldest open PR. Time to have a look? :)

harryhaaren commented 8 years ago

Hi Arnout - sorry, this got totally lost in my inbox apparently. I think at the time I looked at the code, and was worried about hanging notes, although now I can't clearly see the reason why.

I'll look at it again and see what I think. That said, Fabla2 is under very active development, and has much more advanced control over choke-groups, and hence the note on/off ADSRs, perhaps of interest to you if you need this feature as PR-ed here :)

raboof commented 8 years ago

No problem, I'm sure I've got a ton of such issues myself ;).

Currently focused on acoustic music again, but will keep in mind Fabla2 when I get back digital again :).