openAVproductions / openAV-Fabla2

The repository of the Fabla2 sampler by OpenAV. http://openavproductions.com/fabla2
GNU General Public License v2.0
54 stars 13 forks source link

Amplitude Envelope is not recalled #72

Closed unfa closed 6 years ago

unfa commented 6 years ago

Fabla 2 seems to set all the ADSR parameters to 0 at loading the session. Not sure if they re not stored in the first place, or not restored afterwards.

harryhaaren commented 6 years ago

Known issue - the ADSR is incomplete, buggy and not hardened code. Thanks for reporting.

harryhaaren commented 6 years ago

Removed "Ardour" from title to ensure no confusion - this is a Fabla2 issue, and not due to Ardour.

unfa commented 6 years ago

Thanks. This one bug makes Fabla2 pretty unusable for me. If this was fixed I could deploy it more and report more bugs.

harryhaaren commented 6 years ago

Hey @unfa - thanks for the ping on this. Correct - ADSR restore seems to have a bug on restore (as well as other known ADSR issues). Fixing now...

harryhaaren commented 6 years ago

Thanks @unfa for the ping, fixed & merged this quick, given its a trivial fix.